refactor: add standardized constructor to notices #923
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This relates to #899
Summary:
This PR provides additional constructors to notices such as:
CsvParsingFailedNotice
DuplicateRouteNameNotice
BlockTripsWithOverlappingStopTimesNotice
This change is the following: in the process to extract metadata from the
ValidationNotice
subclasses, we intend to leverage the constructor's parameters. However, the aforementioned notices use take exceptions or GtfsRoute as parameters (from which information is extracted in the call tosuper
). Having this additional constructor allows to directly extract information about the parameters for said notices from their constructor.Expected behavior:
No changed behavior.
Please make sure these boxes are checked before submitting your pull request - thanks!
gradle test
to make sure you didn't break anything[ ] Include screenshot(s) showing how this pull request works and fixes the issue(s)