refactor: rename annotation #924
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
July 7, 2021 17:53
…-for-notice-export # Conflicts: # core/src/main/java/org/mobilitydata/gtfsvalidator/notice/CsvParsingFailedNotice.java # main/src/main/java/org/mobilitydata/gtfsvalidator/validator/BlockTripsWithOverlappingStopTimesValidator.java # main/src/main/java/org/mobilitydata/gtfsvalidator/validator/DuplicateRouteNameValidator.java
…-for-notice-export # Conflicts: # core/src/main/java/org/mobilitydata/gtfsvalidator/notice/CsvParsingFailedNotice.java # core/src/main/java/org/mobilitydata/gtfsvalidator/notice/DuplicateKeyNotice.java # core/src/main/java/org/mobilitydata/gtfsvalidator/notice/DuplicatedColumnNotice.java # core/src/main/java/org/mobilitydata/gtfsvalidator/notice/EmptyColumnNameNotice.java # core/src/main/java/org/mobilitydata/gtfsvalidator/notice/EmptyFileNotice.java # core/src/main/java/org/mobilitydata/gtfsvalidator/notice/EmptyRowNotice.java # core/src/main/java/org/mobilitydata/gtfsvalidator/notice/ForeignKeyViolationNotice.java # core/src/main/java/org/mobilitydata/gtfsvalidator/notice/InvalidColorNotice.java # core/src/main/java/org/mobilitydata/gtfsvalidator/notice/InvalidCurrencyNotice.java # core/src/main/java/org/mobilitydata/gtfsvalidator/notice/InvalidDateNotice.java # core/src/main/java/org/mobilitydata/gtfsvalidator/notice/InvalidEmailNotice.java # core/src/main/java/org/mobilitydata/gtfsvalidator/notice/InvalidFloatNotice.java # core/src/main/java/org/mobilitydata/gtfsvalidator/notice/InvalidIntegerNotice.java # core/src/main/java/org/mobilitydata/gtfsvalidator/notice/InvalidLanguageCodeNotice.java # core/src/main/java/org/mobilitydata/gtfsvalidator/notice/InvalidPhoneNumberNotice.java # core/src/main/java/org/mobilitydata/gtfsvalidator/notice/InvalidRowLengthNotice.java # core/src/main/java/org/mobilitydata/gtfsvalidator/notice/InvalidTimeNotice.java # core/src/main/java/org/mobilitydata/gtfsvalidator/notice/InvalidTimezoneNotice.java # core/src/main/java/org/mobilitydata/gtfsvalidator/notice/InvalidUrlNotice.java # core/src/main/java/org/mobilitydata/gtfsvalidator/notice/LeadingOrTrailingWhitespacesNotice.java # core/src/main/java/org/mobilitydata/gtfsvalidator/notice/MissingRequiredColumnNotice.java # core/src/main/java/org/mobilitydata/gtfsvalidator/notice/MissingRequiredFieldNotice.java # core/src/main/java/org/mobilitydata/gtfsvalidator/notice/MissingRequiredFileNotice.java # core/src/main/java/org/mobilitydata/gtfsvalidator/notice/MoreThanOneEntityNotice.java # core/src/main/java/org/mobilitydata/gtfsvalidator/notice/NewLineInValueNotice.java # core/src/main/java/org/mobilitydata/gtfsvalidator/notice/NonAsciiOrNonPrintableCharNotice.java # core/src/main/java/org/mobilitydata/gtfsvalidator/notice/NumberOutOfRangeNotice.java # core/src/main/java/org/mobilitydata/gtfsvalidator/notice/PointNearOriginNotice.java # core/src/main/java/org/mobilitydata/gtfsvalidator/notice/PointNearPoleNotice.java # core/src/main/java/org/mobilitydata/gtfsvalidator/notice/StartAndEndRangeEqualNotice.java # core/src/main/java/org/mobilitydata/gtfsvalidator/notice/StartAndEndRangeOutOfOrderNotice.java # core/src/main/java/org/mobilitydata/gtfsvalidator/notice/UnexpectedEnumValueNotice.java # core/src/main/java/org/mobilitydata/gtfsvalidator/notice/UnknownColumnNotice.java # core/src/main/java/org/mobilitydata/gtfsvalidator/notice/UnknownFileNotice.java # main/src/main/java/org/mobilitydata/gtfsvalidator/validator/AgencyConsistencyValidator.java # main/src/main/java/org/mobilitydata/gtfsvalidator/validator/AttributionWithoutRoleValidator.java # main/src/main/java/org/mobilitydata/gtfsvalidator/validator/BlockTripsWithOverlappingStopTimesValidator.java # main/src/main/java/org/mobilitydata/gtfsvalidator/validator/DuplicateFareRuleZoneIdFieldsValidator.java # main/src/main/java/org/mobilitydata/gtfsvalidator/validator/DuplicateRouteNameValidator.java # main/src/main/java/org/mobilitydata/gtfsvalidator/validator/FeedExpirationDateValidator.java # main/src/main/java/org/mobilitydata/gtfsvalidator/validator/FeedServiceDateValidator.java # main/src/main/java/org/mobilitydata/gtfsvalidator/validator/LocationTypeSingleEntityValidator.java # main/src/main/java/org/mobilitydata/gtfsvalidator/validator/MatchingFeedAndAgencyLangValidator.java # main/src/main/java/org/mobilitydata/gtfsvalidator/validator/MissingCalendarAndCalendarDateValidator.java # main/src/main/java/org/mobilitydata/gtfsvalidator/validator/MissingTripEdgeValidator.java # main/src/main/java/org/mobilitydata/gtfsvalidator/validator/OverlappingFrequencyValidator.java # main/src/main/java/org/mobilitydata/gtfsvalidator/validator/ParentLocationTypeValidator.java # main/src/main/java/org/mobilitydata/gtfsvalidator/validator/RouteColorContrastValidator.java # main/src/main/java/org/mobilitydata/gtfsvalidator/validator/RouteNameValidator.java # main/src/main/java/org/mobilitydata/gtfsvalidator/validator/ShapeIncreasingDistanceValidator.java # main/src/main/java/org/mobilitydata/gtfsvalidator/validator/ShapeUsageValidator.java # main/src/main/java/org/mobilitydata/gtfsvalidator/validator/StopTimeArrivalAndDepartureTimeValidator.java # main/src/main/java/org/mobilitydata/gtfsvalidator/validator/StopTimeIncreasingDistanceValidator.java # main/src/main/java/org/mobilitydata/gtfsvalidator/validator/StopTooFarFromTripShapeValidator.java # main/src/main/java/org/mobilitydata/gtfsvalidator/validator/TimepointTimeValidator.java # main/src/main/java/org/mobilitydata/gtfsvalidator/validator/TooFastTravelValidator.java # main/src/main/java/org/mobilitydata/gtfsvalidator/validator/TripUsabilityValidator.java # main/src/main/java/org/mobilitydata/gtfsvalidator/validator/TripUsageValidator.java
barbeau
reviewed
Jul 9, 2021
There was a problem hiding this comment.
Thanks @lionel-nj, this is better. Suggested wording is below.
core/src/main/java/org/mobilitydata/gtfsvalidator/annotation/SchemaExport.java
Outdated
Show resolved
Hide resolved
added 2 commits
July 12, 2021 08:46
…bilityData/gtfs-validator into task/new-annotation-for-notice-export
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
relates to #899
Summary:
This PR provides support to rename
NoticeExportasSchemaExportfor more clarity.Expected behavior:
No code change for now. Same tests should pass.
Please make sure these boxes are checked before submitting your pull request - thanks!
gradle testto make sure you didn't break anything[ ] Include screenshot(s) showing how this pull request works and fixes the issue(s)