Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: downgrade LeadingOrTrailingWhitespacesNotice to WARNING #929

Merged
merged 4 commits into from
Jul 27, 2021
Merged

chore: downgrade LeadingOrTrailingWhitespacesNotice to WARNING #929

merged 4 commits into from
Jul 27, 2021

Conversation

lionel-nj
Copy link
Contributor

closes #920
Summary:

This PR downgrades LeadingOrTrailingWhitespacesNotice to WARNING.

Expected behavior:

  • Notice should be a WARNING instead of ERROR.
  • Documentation should be updated.

Please make sure these boxes are checked before submitting your pull request - thanks!

  • Run the unit tests with gradle test to make sure you didn't break anything
  • Format the title like "feat: [new feature short description]". Title must follow the Conventional Commit Specification(https://www.conventionalcommits.org/en/v1.0.0/).
  • Linked all relevant issues
  • [ ] Include screenshot(s) showing how this pull request works and fixes the issue(s)

@lionel-nj lionel-nj added the GTFS Reference Used for Adding or changing rules that belong in the GTFS reference label Jul 21, 2021
@lionel-nj lionel-nj self-assigned this Jul 22, 2021
maximearmstrong
maximearmstrong suggested changes Jul 23, 2021
View reviewed changes
docs/NOTICES.md Show resolved Hide resolved
maximearmstrong
maximearmstrong approved these changes Jul 27, 2021
View reviewed changes
Copy link
Contributor

@maximearmstrong maximearmstrong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lionel-nj lionel-nj merged commit fb64846 into master Jul 27, 2021
@lionel-nj lionel-nj deleted the feat/downgrade-LeadingOrTrailingWhitespacesNotice branch July 27, 2021 17:54
@isabelle-dr isabelle-dr mentioned this pull request Oct 28, 2021
Closed
4 tasks
@evansiroky evansiroky mentioned this pull request Jan 10, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maximearmstrong maximearmstrong maximearmstrong approved these changes

Assignees

@lionel-nj lionel-nj

Labels
GTFS Reference Used for Adding or changing rules that belong in the GTFS reference
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make LeadingOrTrailingWhitespacesNotice a WARNING instead of an ERROR
2 participants
@lionel-nj @maximearmstrong