chore: check stop name and desc #937
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lionel-nj
added
the
GTFS Reference
|
This one can stay at the warning severity level, the spec after RFC says:
|
aababilov
reviewed
Sep 5, 2021
| |---------------- |----------------------------------------- |-------- | | ||
| | `csvRowNumber` | The row number of the faulty record. | String | | ||
| | `stopId` | The id of the faulty record. | Long | | ||
| | `routeDesc` | The faulty record's `stop_desc`. | String | |
There was a problem hiding this comment.
typo: should be stopDesc
This is one more argument for removing this file. It is too easy to make a typo and it takes too much effort to catch all mistakes.
There was a problem hiding this comment.
Fixed in PR #1004, opened issue #1006 to discuss the issues we have with NOTICES.md
main/src/main/java/org/mobilitydata/gtfsvalidator/validator/StopNameValidator.java
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #910
Summary:
This PR provides support to implement a new rule described in #910
Expected behavior:
New
ValidationNotice:SameNameAndDescriptionForStopNotice(severity level:WARNING- to be upgraded toERRORin the future.A notice should be generated for each record from
stops.txtwherestops.stop_des == stops.stop_name.Please make sure these boxes are checked before submitting your pull request - thanks!
gradle testto make sure you didn't break anything[ ] Include screenshot(s) showing how this pull request works and fixes the issue(s)