feat: Validate that pathway endpoints have correct types #961
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* a pathway may not lead to a station (location_type=1); * if a platform has boarding areas, the pathway must be connected to its boarding areas instead of the platform itself.
lionel-nj
suggested changes
Aug 18, 2021
There was a problem hiding this comment.
Thanks @aababilov for your contribution - one comment in-line regarding the naming of PathwayWrongEndpointTypeNotice.
main/src/main/java/org/mobilitydata/gtfsvalidator/validator/PathwayEndpointTypeValidator.java
Outdated
Show resolved
Hide resolved
7 tasks
maximearmstrong
approved these changes
Aug 18, 2021
aababilov
added a commit
to aababilov/gtfs-validator
that referenced
this pull request
Aug 30, 2021
It is superseded by PathwayEndpointTypeValidator - see pull MobilityData#961
aababilov
added a commit
that referenced
this pull request
Aug 31, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
its boarding areas instead of the platform itself.