Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: verify gradle wrapper #964

Merged
merged 2 commits into from
Aug 17, 2021
Merged

ci: verify gradle wrapper #964

merged 2 commits into from
Aug 17, 2021

Conversation

lionel-nj
Copy link
Contributor

@lionel-nj lionel-nj commented Aug 17, 2021

relates to #734

Summary:

This PR provides support to verify the gradle wrapper by adding a job to the test_pack_docworkflow.

This adds additional security/integrity to ensure that any changes to the wrapper match an official Gradle release.
(from #963 (review))

Said job is required to execute test, packaging and documentation jobs.

Expected behavior:

Workflows fail if the SHA-256 checksum does not match an official release from Gradle.

Please make sure these boxes are checked before submitting your pull request - thanks!

  • [ ] Run the unit tests with gradle test to make sure you didn't break anything
  • Format the title like "feat: [new feature short description]". Title must follow the Conventional Commit Specification(https://www.conventionalcommits.org/en/v1.0.0/).
  • Linked all relevant issues
  • [ ] Include screenshot(s) showing how this pull request works and fixes the issue(s)

@lionel-nj lionel-nj self-assigned this Aug 17, 2021
@barbeau
Copy link
Member

barbeau commented Aug 17, 2021

@lionel-nj Could you add this to all the workflows? It should be the very first step in any workflow that executes Gradle so that if the validation of the wrapper fails no additional steps in the workflow should be executed.

@lionel-nj
Copy link
Contributor Author

@lionel-nj Could you add this to all the workflows? It should be the very first step in any workflow that executes Gradle so that if the validation of the wrapper fails no additional steps in the workflow should be executed.

Done in 179dae0.

Copy link
Member

@barbeau barbeau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@lionel-nj lionel-nj merged commit ccc2e4d into master Aug 17, 2021
@lionel-nj lionel-nj deleted the ci/validate-gradle-wrapper branch August 17, 2021 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants