feat: Validate that a generic node is not dangling #998
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A dangling node has just one incident location in the pathway graph. Such generic node is useless because there is no benefit in visiting it.
aababilov
force-pushed
the
PathwayDanglingGenericNodeValidator
branch
from
a80c30c
to
100f818
Compare
|
I had to resolve a merge conflict in RULES.md and I also updated NOTICES.md which will lead to another merge conflict with another PR. We really need to do something with that. |
isabelle-dr
approved these changes
Sep 2, 2021
|
Thanks for review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A dangling node has just one incident location in the pathway graph.
Such generic node is useless because there is no benefit in visiting it.