feat: complete registration screen #151
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Preview Firebase Hosting URL: https://mobility-feeds-dev--pr-151-cvxsi2cq.web.app |
davidgamez
reviewed
Nov 2, 2023
Comment on lines
50
to
53
| await updateProfile(user, { | ||
| displayName: values?.fullname, | ||
| }); | ||
| dispatch(refreshUserInformation(user)); |
There was a problem hiding this comment.
This operation should be abstracted from the component. The update of the profile should be in the saga layer not the component.
| }); | ||
| dispatch(refreshUserInformation(user)); | ||
|
|
||
| navigateTo(ACCOUNT_TARGET); |
There was a problem hiding this comment.
The navigation should be done after the network call is succeeded. We need to add error handling in case a network call fails.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Closes #148
This PR is only covering the UI components related to the registration process. The logic will need to be implemented as tested as part of the upcoming issues.
Tasks left to completion to ensure proper behaviour of user registration:
CompleteRegistration.tsxpage i.e. Add Captcha to CompleteRegistration and Signup screen #152Expected behavior:
Please make sure these boxes are checked before submitting your pull request - thanks!
./scripts/api-tests.shto make sure you didn't break anything