Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 155 currentuser is always null on the first call of appauth #167

Merged

Conversation

qcdyx
Copy link
Contributor

@qcdyx qcdyx commented Nov 15, 2023

Summary:

Closes #155
Expected behavior:

  1. Login
  2. Open developer console, choose slow 3G as network setting
  3. Click Refresh button of browser
  4. You'll see a spinner
  5. Click Generate Access Token
  6. You'll see the token generated

Testing tips:

Provide tips, procedures and sample files on how to test the feature.
Testers are invited to follow the tips AND to try anything they deem relevant outside the bounds of the testing tips.

Please make sure these boxes are checked before submitting your pull request - thanks!

  • Run the unit tests with ./scripts/api-tests.sh to make sure you didn't break anything
  • Format the title like "feat: [new feature short description]". Title must follow the Conventional Commit Specification(https://www.conventionalcommits.org/en/v1.0.0/).
  • Linked all relevant issues
  • Include screenshot(s) showing how this pull request works and fixes the issue(s)

@qcdyx qcdyx linked an issue Nov 15, 2023 that may be closed by this pull request
Copy link

Preview Firebase Hosting URL: https://mobility-feeds-dev--pr-167-ic2zge1n.web.app

Copy link
Member

@davidgamez davidgamez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@qcdyx qcdyx merged commit 192194f into main Nov 15, 2023
4 checks passed
@qcdyx qcdyx deleted the 155-currentuser-is-always-null-on-the-first-call-of-appauth branch November 15, 2023 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CurrentUser is always null on the first call of app.auth()
2 participants