Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add search box to home page #546

Merged
merged 5 commits into from
Jul 10, 2024
Merged

feat: add search box to home page #546

merged 5 commits into from
Jul 10, 2024

Conversation

indraneel
Copy link
Collaborator

Summary:

Should close what's left of #347

image

Expected behavior:

  • makes a Search box available on home page
  • navigates to /feeds?q=<search query> w/ search text contents

Testing tips:

  • type in search query and press "enter" key or click "search" button

Please make sure these boxes are checked before submitting your pull request - thanks!

  • Run the unit tests with ./scripts/api-tests.sh to make sure you didn't break anything
  • Add or update any needed documentation to the repo
  • Format the title like "feat: [new feature short description]". Title must follow the Conventional Commit Specification(https://www.conventionalcommits.org/en/v1.0.0/).
  • Linked all relevant issues
  • Include screenshot(s) showing how this pull request works and fixes the issue(s)

Copy link

github-actions bot commented Jul 9, 2024

Preview Firebase Hosting URL: https://mobility-feeds-dev--pr-546-astwlv79.web.app

@emmambd emmambd self-requested a review July 9, 2024 20:16
@Alessandro100
Copy link
Contributor

[small] For the search button, can you add the style height: '55px' so the button matches the height of the input and matches the search page styling?

Copy link
Contributor

@Alessandro100 Alessandro100 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

left a small styling comment but otherwise works great!

@emmambd
Copy link
Contributor

emmambd commented Jul 10, 2024

@indraneel Minor edit re: placeholder test (e.g. "New York" or "Carris Metropolitana")

@davidgamez
Copy link
Member

A question for @emmambd, what is the expected behavior of a click in the search button with empty search? Currently, nothing happens. At the feeds page, a search is executed, returning the first page of all feeds results

@emmambd
Copy link
Contributor

emmambd commented Jul 10, 2024

@davidgamez Good point - it should be the same behavior as the feeds page (empty = returns all feeds)

@emmambd
Copy link
Contributor

emmambd commented Jul 10, 2024

Also, would be nice for the buttons not to have drop shadow (original design was flat)

@indraneel
Copy link
Collaborator Author

image

@indraneel
Copy link
Collaborator Author

@emmambd is this what you meant?
image

Copy link
Member

@davidgamez davidgamez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@indraneel indraneel merged commit 393c94d into main Jul 10, 2024
4 checks passed
@indraneel indraneel deleted the feat/347_home-search branch July 10, 2024 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants