-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add search box to home page #546
Conversation
Preview Firebase Hosting URL: https://mobility-feeds-dev--pr-546-astwlv79.web.app |
[small] For the search button, can you add the style |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
left a small styling comment but otherwise works great!
@indraneel Minor edit re: placeholder test (e.g. "New York" or "Carris Metropolitana") |
A question for @emmambd, what is the expected behavior of a click in the search button with empty search? Currently, nothing happens. At the feeds page, a search is executed, returning the first page of all feeds results |
@davidgamez Good point - it should be the same behavior as the feeds page (empty = returns all feeds) |
Also, would be nice for the buttons not to have drop shadow (original design was flat) |
- make it taller (55px) - remove drop shadow
@emmambd is this what you meant? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Summary:
Should close what's left of #347
Expected behavior:
/feeds?q=<search query>
w/ search text contentsTesting tips:
Please make sure these boxes are checked before submitting your pull request - thanks!
./scripts/api-tests.sh
to make sure you didn't break anything