Fix sample spec #50
Merged
Fix sample spec #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Concretely:
- change all start and end locs to geojson
- points for the calibration trips
- polygons for the evaluation trips
- add all trajectories as polylines
this still fails some validation checks but let's check it in for now
before making any further changes
- fix the calibration mapping for the validation notebook
- fix the notebook to create ground truth for leg by:
- adding multiple examples of methods to find the trajectories
- fixed the mapping to the new format
- fix the spec
- change the 52 bus stop polygon to match
- fix the polygon for the foothill bus stop to not overlap the trajectory
- fix the trajectory of the foothill walk to avoid repeated points
- fix the formatting of other polygons to not be as verbose
so that it doesn't report errors if all entries between the duplicates are also duplicates. Concretely, if entries 31,32 and 33 are all duplicates, the previous code would have returned an error. But it is not really an error, since there would not be any zigzag, just repeated points. This checks the intermediate points to see if they are identical as well by adding an addition `for` loop.
|
@singhish this has some fixes to the validation code
Can you also please add an inline test for the polygon checks when you are fixing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This helps with e-mission/e-mission-docs#624
by bringing the sample up to the modified spec format