Skip to content
This repository has been archived by the owner on Dec 7, 2021. It is now read-only.

Close XSS Vector #120

Merged
merged 1 commit into from May 29, 2019
Merged

Conversation

adrian-enspired
Copy link
Contributor

fixes #102

Found another bad use of innerHTML in addition to those fixed in #100

Note, this changes how the match function works:

  • match now always returns a boolean (as its docblock claims ; )
  • the contents of the provided option are now modified in-place (no more returning HTML as a string)

It seems the match function is only being used in one place, so these changes should not cause any unexpected behavior.

@adrian-enspired
Copy link
Contributor Author

I also noted the use of innerHTML when assigning placeholder values. I did not change this as I expect users may be passing HTML to the placeholder config option deliberately, and changes would break existing usage. This should probably be more closely reviewed, however.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Xss vulnerable
2 participants