Fix reference error when leaderboard is disabled

Mobius1 · Oct 7, 2020 · 6f1303c · 6f1303c
1 parent 6829866
commit 6f1303c
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 3 deletions.
diff --git a/ui/js/app.js b/ui/js/app.js
@@ -50,7 +50,9 @@ function fillSegments(pr, child) {
 }
 
 function TriggerRankChange(rankUp, current, previous) {
-    leaderboard.updateRank(currentID, current)
+    if ( leaderboard && currentID ) {
+        leaderboard.updateRank(currentID, current);
+    }
 
     fetch(`https://${GetParentResourceName()}/xpm_rankchange`, {
         method: 'POST',

diff --git a/ui/js/class.leaderboard.js b/ui/js/class.leaderboard.js
@@ -134,7 +134,9 @@ class Leaderboard {
     }
 
     updateRank(id, rank) {
-        this.players[id].rank = rank;
-        this.players[id].row.querySelector(".xpm-leaderboard--playerranknum").textContent = rank;
+        if ( id in this.players ) {
+            this.players[id].rank = rank;
+            this.players[id].row.querySelector(".xpm-leaderboard--playerranknum").textContent = rank;
+        }
     }    
 }