Skip to content

wip: add support for js and add improvements to paging #14

wip: add support for js and add improvements to paging

wip: add support for js and add improvements to paging #14

Triggered via push November 13, 2023 19:35
Status Failure
Total duration 25s
Artifacts

lint.yml

on: push
run-swiftlint
13s
run-swiftlint
run-swiftformat
16s
run-swiftformat
Fit to window
Zoom out
Zoom in

Annotations

1 error and 20 warnings
run-swiftformat
Process completed with exit code 1.
run-swiftlint: Sources/Clients/UserSettingsClient/Live.swift#L26
TODOs should be resolved (Save UserSettingsClient) (todo)
run-swiftlint: Sources/Clients/ModuleClient/Live.swift#L55
TODOs should be resolved (Check if the module is cached ...) (todo)
run-swiftlint: Sources/Clients/ModuleClient/JS+Bindings/JSContext+JSRuntime.swift#L254
Line should be 150 characters or less; currently it has 157 characters (line_length)
run-swiftlint: Sources/Clients/ModuleClient/JS+Bindings/JSContext+JSRuntime.swift#L254
Operators should be surrounded by a single whitespace when they are being used (operator_usage_whitespace)
run-swiftlint: Sources/Clients/PlayerClient/Internal/PlayerItem.swift#L41
TODOs should be resolved (Validate if this is allowed or...) (todo)
run-swiftlint: Sources/Clients/PlayerClient/PlayerFeature/PlayerFeature.swift#L17
TODOs should be resolved (Move this to Player Client) (todo)
run-swiftlint: Sources/Clients/PlayerClient/Internal/PlayerItem+HLS.swift#L214
TODOs should be resolved (Build main playlist non-multiv...) (todo)
run-swiftlint: Sources/Clients/AnalyticsClient/Live.swift#L12
TODOs should be resolved (Implement analytics to better ...) (todo)
run-swiftlint: Sources/Features/Settings/SettingsFeature+View.swift#L24
TODOs should be resolved (Actually allow users to set wh...) (todo)
run-swiftlint: Sources/Features/ContentCore/ContentCore.swift#L77
FIXMEs should be resolved (Force should modify the respec...) (todo)
run-swiftformat: Tests/ModuleClientTests/JSRunnerTests.swift#L3
Remove trailing space at end of a line. (trailingSpace)
run-swiftformat: Tests/ModuleClientTests/JSRunnerTests.swift#L6
Remove trailing space at end of a line. (trailingSpace)
run-swiftformat: Tests/ModuleClientTests/ModuleClientTests.swift#L7
Remove leading blank line at the start of a scope. (blankLinesAtStartOfScope)
run-swiftformat: Tests/JSValueCoderTests/JSValueCoderTests.swift#L3
Remove trailing space at end of a line. (trailingSpace)
run-swiftformat: Tests/JSValueCoderTests/JSValueCoderTests.swift#L6
Remove trailing space at end of a line. (trailingSpace)
run-swiftformat: Tests/JSValueCoderTests/JSValueCoderTests.swift#L32
Move inline try keyword(s) to start of expression. (hoistTry)
run-swiftformat: Tests/JSValueCoderTests/JSValueCoderTests.swift#L34
Move inline try keyword(s) to start of expression. (hoistTry)
run-swiftformat: Tests/JSValueCoderTests/JSValueCoderTests.swift#L62
Insert/remove explicit self where applicable. (redundantSelf)
run-swiftformat: Tests/JSValueCoderTests/JSValueCoderTests.swift#L73
Insert/remove explicit self where applicable. (redundantSelf)
run-swiftformat: Tests/JSValueCoderTests/JSValueCoderTests.swift#L76
Remove trailing blank line at the end of a scope. (blankLinesAtEndOfScope)