Detect model type automatically #209
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The fact that the metadata must be parseable already filters out invalid models from the list, and the removal of the popover fixes the crashes, but a log never hurts.
|
Very nice! I'll pull the changes and take a look today or tomorrow. |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had a flash of inspiration yesterday, and found a way to distinguish original/split-einsum models without introducing custom JSONs or anything extra into/around the models.
This renders the unit selection popover unnecessary too, so I dropped that and introduced a new setting as the "compute unit preference", replacing the previous, directly set MLComputeUnits. The default for everyone is Auto, but advanced users can force a specific unit in Settings/Image as before. Help labels are updated to match.
Fixes #193 and #170 (since the offending popover and race condition is gone).
(And I found a fun race condition when selecting a new model and pressing Generate twice causing two images to be rendered at the same time, but there's no open issue for it.)