Implement getOfflinePlayerIfCached with tests (#947)

* Implement getOfflinePlayerIfCached with tests

* Fix formatting

* Fix more formatting

src/main/java/be/seeseemelk/mockbukkit/MockPlayerList.java

@@ -356,21 +356,11 @@ public PlayerMock getPlayer(int index)
 	@NotNull
 	public OfflinePlayer getOfflinePlayer(@NotNull String name)
 	{
-		Player player = getPlayer(name);
-
-		if (player != null)
-		{
-			return player;
-		}
-
-		for (OfflinePlayer offlinePlayer : this.offlinePlayers)
+		OfflinePlayer offlinePlayer = getOfflinePlayerIfCached(name);
+		if (offlinePlayer != null)
 		{
-			if (name.equals(offlinePlayer.getName()))
-			{
-				return offlinePlayer;
-			}
+			return offlinePlayer;
 		}
-
 		return new OfflinePlayerMock(name);
 	}
 
@@ -438,4 +428,23 @@ public void removeOperator(UUID operator)
 		this.operators.remove(operator);
 	}
 
+	public @Nullable OfflinePlayer getOfflinePlayerIfCached(String name)
+	{
+		Player player = getPlayer(name);
+
+		if (player != null)
+		{
+			return player;
+		}
+
+		for (OfflinePlayer offlinePlayer : this.offlinePlayers)
+		{
+			if (name.equals(offlinePlayer.getName()))
+			{
+				return offlinePlayer;
+			}
+		}
+		return null;
+	}
+
 }

src/main/java/be/seeseemelk/mockbukkit/ServerMock.java

@@ -588,8 +588,7 @@ public boolean removeWorld(WorldMock world)
 	@Override
 	public @Nullable OfflinePlayer getOfflinePlayerIfCached(@NotNull String name)
 	{
-		//TODO Auto-generated method stub
-		throw new UnimplementedOperationException();
+		return playerList.getOfflinePlayerIfCached(name);
 	}
 
 	@Override

src/test/java/be/seeseemelk/mockbukkit/ServerMockTest.java

@@ -80,7 +80,6 @@
 import org.jetbrains.annotations.NotNull;
 import org.junit.jupiter.api.AfterEach;
 import org.junit.jupiter.api.BeforeEach;
-import org.junit.jupiter.api.RepeatedTest;
 import org.junit.jupiter.api.Test;
 import org.junit.jupiter.params.ParameterizedTest;
 import org.junit.jupiter.params.provider.Arguments;
@@ -1647,6 +1646,31 @@ void testGetIPBans()
 
 	}
 
+	@Test
+	void testGetOfflinePlayerIfCached_notRegistered()
+	{
+		String name = "headstalls";
+		OfflinePlayer offlinePlayer = server.getOfflinePlayerIfCached(name);
+		assertNull(offlinePlayer);
+	}
+
+	@Test
+	void testGetOfflinePlayerIfCached_offlinePlayerRegistered()
+	{
+		PlayerMock playerMock = server.addPlayer("CapitalizedName");
+		playerMock.disconnect();
+		OfflinePlayer offlinePlayer = server.getOfflinePlayerIfCached(playerMock.getName());
+		assertEquals(playerMock, offlinePlayer);
+	}
+
+	@Test
+	void testGetOfflinePlayerIfCached_playerRegistered()
+	{
+		PlayerMock playerMock = server.addPlayer("CapitalizedName");
+		OfflinePlayer offlinePlayer = server.getOfflinePlayerIfCached(playerMock.getName());
+		assertEquals(playerMock, offlinePlayer);
+	}
+
 }
 
 class TestRecipe implements Recipe