feat(world): Implement Logical Height (#924)

MockBukkit · Dec 7, 2023 · 88d24d2 · 88d24d2
1 parent 1c28b83
commit 88d24d2
Show file tree

Hide file tree

Showing 2 changed files with 19 additions and 2 deletions.
diff --git a/src/main/java/be/seeseemelk/mockbukkit/WorldMock.java b/src/main/java/be/seeseemelk/mockbukkit/WorldMock.java
@@ -2931,8 +2931,12 @@ public double getHumidity(int x, int y, int z)
 	@Override
 	public int getLogicalHeight()
 	{
-		// TODO Auto-generated method stub
-		throw new UnimplementedOperationException();
+		return switch (environment)
+		{
+			case NETHER, THE_END -> 256;
+			case NORMAL -> 384;
+			case CUSTOM -> throw new UnimplementedOperationException("We don't have support for Datapacks");
+		};
 	}
 
 	@Override

diff --git a/src/test/java/be/seeseemelk/mockbukkit/WorldMockTest.java b/src/test/java/be/seeseemelk/mockbukkit/WorldMockTest.java
@@ -2142,4 +2142,17 @@ void testGetEntityWrongWorld()
 		assertNull(world2.getEntity(entity.getUniqueId()));
 	}
 
+	@Test
+	void testGetLogicalHeight()
+	{
+		WorldMock world = new WorldMock(Material.DIRT, 3);
+		assertEquals(384, world.getLogicalHeight());
+
+		world.setEnvironment(World.Environment.NETHER);
+		assertEquals(256, world.getLogicalHeight());
+
+		world.setEnvironment(World.Environment.THE_END);
+		assertEquals(256, world.getLogicalHeight());
+	}
+
 }