Unit tests for DamageSourceMock

[4everTheOne]

Description

Added unit tests for class DamageSourceMock (Related with #479).
This also includes commit 49e2007 which is a fix for pipeline to build.

Checklist

The following items should be checked before the pull request can be merged.

• Code follows existing style.
• Unit tests added (if applicable).

[Thorinwasher]

Really good that you noticed this! (I was the one that missed adding a testcase for this class).

I have some minor requested changes, but overall good.

[4everTheOne]

Hi @Thorinwasher, thank you for the review!

I have migrated the logic from constructor to a method DamageTypeMock#from(JsonObject) in commit 1cb49f0. I think this approach allow us to have the best of both worlds! But let me know your opinion on that :)

[Thorinwasher]

Good idea to with the DamageTypeMock.from(JsonObject) function. Definittely better than using a constructor!

On that, I plan on making a new pull request that applies this on all other keyed objects (but that has to be in a different pull request)

[sonarcloud]

Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

[4everTheOne]

I followed your suggestion , and I think the current state is a good trade-off between complexity and code readability.
This was achieved by converting the information from JSON to a record and replacing the ValueSource with MethodSource.

[Thorinwasher]

Looks good to me