-
Notifications
You must be signed in to change notification settings - Fork 128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implementing respawn location. #998
Implementing respawn location. #998
Conversation
I recomend looking into the Paper code for this, as our behavior in mockbukkit is meant to copy that of paper. Anyhow for your specific question; it looks like there is only one variable that defines the respawn location in Paper. The bed respawn location is that location, here's the implementation of one of the methods: public Location getBedSpawnLocation() {
return this.getRespawnLocation();
} I hope that clears that up for you |
Thanks for the hint @Thorinwasher! I have now a copy of the papers code on my computer. |
Good! Now you need to change the formatting of the code to follow the same style as everything else. |
No |
{ | ||
return bedSpawnLocation; | ||
} | ||
public @Nullable Location getRespawnLocation() { return this.respawnLocation; } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This here is what I meant reformat the code. Here's an example
public @Nullable Location getRespawnLocation() { return this.respawnLocation; } | |
public @Nullable Location getRespawnLocation() | |
{ | |
return this.respawnLocation; | |
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, this should have been reformatted now.
c61fe2f
to
c730e75
Compare
Quality Gate passedIssues Measures |
Description
Adding respawn location attribute.
Creating this as a draft because I see there is a
respawn
function available (and tested). But I don't know exactly what.respawn()
should do: should it go to the respawn location, or to the bed? What happens exactly?Checklist
The following items should be checked before the pull request can be merged.