Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Latest release removes semver #7

Closed
odlevakp opened this issue Mar 8, 2016 · 2 comments
Closed

Latest release removes semver #7

odlevakp opened this issue Mar 8, 2016 · 2 comments
Assignees

Comments

@odlevakp
Copy link

odlevakp commented Mar 8, 2016

Hey,

we are using modlean for quite some time, unfortunately the latest release (1.2.6) started to break our docker builds/node api:

Error: Cannot find module 'semver'
    at Function.Module._resolveFilename (module.js:326:15)
    at Function.Module._load (module.js:277:25)
    at Module.require (module.js:354:17)
    at require (internal/module.js:12:17)
    at Object.<anonymous> (/opt/api/node_modules/loopback-boot/lib/executor.js:2:14)
    at Module._compile (module.js:410:26)
    at Module._extensions..js (module.js:417:10)
    at Object.require.extensions.(anonymous function) [as .js] (/opt/api/node_modules/babel-core/lib/api/register/node.js:214:7)
    at Module.load (module.js:344:32)
    at Function.Module._load (module.js:301:12)
module.js:328
    throw err;

This is because the semver safe pattern was added. Would it be feasible to add a CLI option for specifying a JSON list of patterns to exclude, for instance --ignore=keep_us.json, or even .modcleanignore?
That way we could keep a small ignore json in our repository.

KyleRoss added a commit that referenced this issue Mar 8, 2016
@KyleRoss KyleRoss self-assigned this Mar 8, 2016
@KyleRoss
Copy link
Member

KyleRoss commented Mar 8, 2016

I moved a few of the patterns to danger to prevent issues. Version 1.2.7 has been published to NPM. Thanks for reporting this.

As for the suggestion, it will be definitely something new that I will add in the near future.

@odlevakp
Copy link
Author

odlevakp commented Mar 9, 2016

Works again with 1.2.7, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants