Skip to content
This repository has been archived by the owner on Dec 30, 2022. It is now read-only.

ThatOrThis compatibility #50

Closed
Felix14-v2 opened this issue Sep 4, 2021 · 5 comments
Closed

ThatOrThis compatibility #50

Felix14-v2 opened this issue Sep 4, 2021 · 5 comments

Comments

@Felix14-v2
Copy link
Contributor

Felix14-v2 commented Sep 4, 2021

Problem
ThatOrThis is a mod that allows you to load mods from additional directories (for e.g. 'mods\Technical\GUI\ModManager'). At the moment, ModManager shows this error while trying to update such mods:
.java.lang.Exception: Couldn't find jar for [modname]
( at Not Enough Crashes deobfuscated stack trace.(1.17.1+build.31) ~[?:?])
. at xyz.deathsgun.modmanager.tasks.ModUpdateTask.execute(ModUpdateTask.java:40) ~[modmanager-1.0.2+1.17-alpha.jar:?]
. at xyz.deathsgun.modmanager.api.manipulation.ManipulationTask.executeTask(ManipulationTask.java:47) [modmanager-1.0.2+1.17-alpha.jar:?]
. at xyz.deathsgun.modmanager.services.ManipulationService.run(ManipulationService.java:49) [modmanager-1.0.2+1.17-alpha.jar:?]

Decision
Is it possible to add checking of custom paths from thatorthis configs (config\thatorthis\rules.json)?
I hope, this should be useful.

@DeathsGun
Copy link
Member

Yeah this shouldn't be that much work

@RoboMico
Copy link
Contributor

RoboMico commented Sep 4, 2021

I don't think this is a compatibility issue. I have got the same problem before when trying to update other mods, and it has just gone after several days. Maybe it is just because of Modrinth's API issue or network lag. But ModManager could do something on itself to work out this problem.

@DeathsGun
Copy link
Member

DeathsGun commented Sep 4, 2021

ModManager looks only in mods/ for jar files so it only needs to also look in subdirectories.
And for the error that it can't find the jar is now handled differently than in the kotlin rewrite. It will check first if the jar file exists and then for updates for the mod

@DeathsGun
Copy link
Member

Did you test this again with 1.1.0?

@Felix14-v2
Copy link
Contributor Author

Of course, works perfectly 👍
I think, this issue can be closed. If I will find some problems, we can always reopen it.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants