Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to set non-default port on xsbug-log #1062

Closed
bartbutenaers opened this issue Mar 13, 2023 · 3 comments
Closed

Unable to set non-default port on xsbug-log #1062

bartbutenaers opened this issue Mar 13, 2023 · 3 comments
Labels
confirmed issue reported has been reproduced

Comments

@bartbutenaers
Copy link

Build environment: Linux on Raspberry
Target device: wt32-eth01

Description

@ralphwetzel was investigating an issue for me, and he found out that it is not possible to set a custom port (5004) on xsbug-log via the "-x" parameter. As you can see in his log, xsbug-log keeps listening to the default port (5002):

>> IDF_PYTHON_ENV_PATH: /home/ralph/.espressif/python_env/idf4.4_py3.10_env
>> mcconfig -d -x localhost:5004 -l -m -p esp32/wt32_eth01 -t xsbug
/home/ralph/esp32/esp-idf/tools/idf.py
# starting xsbug
# xsbug-log listening on port 5002. ^C to exit

Steps to Reproduce

  1. Run the above command
  2. See in the log that it starts listening to the default port

Expected behavior

That xsbug-log starts listening at the port specified with the "-x" parameter.

Thanks!!
Bart

@phoddie
Copy link
Collaborator

phoddie commented Mar 13, 2023

Thank you for the report.

I successfully tested a fix on macOS. Perhaps you can try the parallel change on your Linux set-up? Change line 399 of make.esp32.mk to:

DO_LAUNCH := cd $(MODDABLE)/tools/xsbug-log && XSBUG_PORT=$(XSBUG_PORT) node xsbug-log $(LOG_LAUNCH)

@phoddie phoddie added the confirmed issue reported has been reproduced label Mar 13, 2023
@bartbutenaers
Copy link
Author

Evening @phoddie,

Thanks a lot for your fast support!!!
I can indeed confirm that (after applying your fix) xsbug-log now indeed start listening on port 5004 via Ralph's sidebar.
So you can close this issue!

Bart

@phoddie
Copy link
Collaborator

phoddie commented Mar 13, 2023

Very nice! Thank you for the quick confirmation. (the changes will be included in our next Moddable SDK update)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
confirmed issue reported has been reproduced
Projects
None yet
Development

No branches or pull requests

2 participants