Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should examples/drivers/sensors include manifest_base? #1201

Closed
stc1988 opened this issue Aug 27, 2023 · 2 comments
Closed

Should examples/drivers/sensors include manifest_base? #1201

stc1988 opened this issue Aug 27, 2023 · 2 comments

Comments

@stc1988
Copy link
Contributor

stc1988 commented Aug 27, 2023

Build environment: macOS
Moddable SDK version: 4.0.0-23-g2f9eb25dc
Target device: esp32/m5stack
Steps to Reproduce

cd $MODDABLE/examples/drivers/sensors/sht3x
mcconfig -d -m -p esp32/m5stack -t build
### Error: 'undefined/network/wifi/manifest.json': manifest not found!

Other information
I think this issue is affected by e837525.

Including "(MODDABLE)/examples/manifest_base.json make it works.

@phoddie
Copy link
Collaborator

phoddie commented Aug 27, 2023

Yes!

There was a mistake in $MODDABLE/modules/io/manifest.json. It included manifest_base.json, but it should not. Only the project manage should do that. We corrected this in the nRF52 / Moddable Four work. Unfortunately, it caused problems with examples that depended on io/manifest.json to include manifest_base.json. I'll review examples/drivers/sensors and examples/drivers/rtc to add manifest_base.json where needed.

Sorry for the trouble. Thanks for the report and precise analysis.

@phoddie
Copy link
Collaborator

phoddie commented Sep 11, 2023

Closing as this should now be resolved. If there are remaining issues, please re-open. Thank you.

@phoddie phoddie closed this as completed Sep 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants