Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error when build examples/piu/color-picker #1303

Closed
stc1988 opened this issue Feb 3, 2024 · 2 comments
Closed

Error when build examples/piu/color-picker #1303

stc1988 opened this issue Feb 3, 2024 · 2 comments

Comments

@stc1988
Copy link
Contributor

stc1988 commented Feb 3, 2024

Build environment: macOS,
Moddable SDK version: 70f8bf1
Target device: MacOS

Steps to Reproduce

  1. Build the app examples/piu/color-picker using this build command: mcconfig -d -m -p mac
  2. See error
ReferenceError: module "commodetto/Poco" not found
### ReferenceError: module "commodetto/Poco" not found!
make: *** [/Users/Satoshi/Projects/moddable/build/tmp/mac/mc/debug/color-picker/mc.xs.c] Error 22
make: *** Waiting for unfinished jobs....

I think this issue caused by commit 9b84b4b.

@phoddie
Copy link
Collaborator

phoddie commented Feb 3, 2024

Thanks you for the report. Your analysis is correct. We changed the manifests to reduce code size for Piu apps that do not use Poco JavaScript APIs (which is most of them). Those apps now need to include Commodetto direct. This smaller code size is particularly helpful for devices with less flash space (like Moddable Four and Moddable One) The color picker didn't get updated.

The change is easy. In $MODDABLE/modules/input/color-picker/manifest.json update the includes section:

    "include": [
        "$(MODDABLE)/examples/manifest_piu.json",
        "$(MODDABLE)/examples/manifest_commodetto.json"
    ]

We'll get this integrated into the SDK.

@phoddie
Copy link
Collaborator

phoddie commented Feb 7, 2024

Closing as fixed.

@phoddie phoddie closed this as completed Feb 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants