Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Invalid JSON is manifest.json module #476

Closed
erights opened this issue Oct 16, 2020 · 2 comments
Closed

Invalid JSON is manifest.json module #476

erights opened this issue Oct 16, 2020 · 2 comments
Labels
confirmed issue reported has been reproduced fixed - please verify Issue has been fixed. Please verify and close.

Comments

@erights
Copy link

erights commented Oct 16, 2020

moddable/examples/helloworld/manifest.json

Line 7 in 6165841

},

The JSON grammar does not include trailing commas.
@phoddie
Copy link
Collaborator

phoddie commented Oct 16, 2020

Yes, we keep meaning to fix that. We should actually follow through. ;)

@phoddie phoddie added the confirmed issue reported has been reproduced label Oct 16, 2020
mkellner pushed a commit that referenced this issue Oct 20, 2020
@phoddie
remove non-conforming commas from manifests #476
ebbfde4
@phoddie phoddie added the fixed - please verify Issue has been fixed. Please verify and close. label Oct 20, 2020
@dckc
Copy link
Contributor

dckc commented Oct 21, 2020

I plan to verify this; especially to check whether any of the manifests I added to agoric-sdk have trailing commas.

@phoddie phoddie closed this as completed Oct 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
confirmed issue reported has been reproduced fixed - please verify Issue has been fixed. Please verify and close.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@dckc @erights @phoddie