WiFiModule Allow PSK instead of password

[MKGaru]

Describe
WiFi Module Allow PSK instead of password

Why do you think this feature would be useful?
There is a slight security advantage as it avoids storing raw passwords.

Proposal change

moddable/modules/network/wifi/esp/modwifi.c

Line 133 in 5df3b55

if (c_strlen(str) > (sizeof(config.password) - 1))

moddable/modules/network/wifi/esp32/xs6wifi.c

Line 183 in 5df3b55

if (espStrLen(str) > (sizeof(config.sta.password) - 1))

remove -1 both files.
(both source use memcpy, not strcpy , because maybe not required terminate null charactor)

I tried on esp32, it works.

ref.
http://jorisvr.nl/wpapsk.html
esp8266/Arduino/pull/1850

[phoddie]

Interesting. It is nice that the password wouldn't need to be stored, though the PSK value still allows log-in to the network, so that should still be secured in a real product.

It seems like the password and PSK are not quite the same. I'm not sure if there should be a different name in JavaScript to distinguish those (config.psk instead of config.password). If everyone else is already overloading password, maybe we should do the same.

[wilberforce]

How do you generate the PSK?

[wilberforce]

https://www.wireshark.org/tools/wpa-psk.html
pbkdf2.js might be useful - then the same ssid and password in the manifest could be used and they could be converted to the psk for use on the device.

[phoddie]

Sorry to be so slow The proposed change makes sense. Even macOS allows a 64 character password, so we should just always do that. This will be included in tomorrow's Moddable SDK update. Thank you!

[phoddie]

Closing as the proposed change has been applied.

[MKGaru]

Closing as the proposed change has been applied.

Thank you so much!
By the way, you applied for access point ssid & password, but i think should be change sta mode too.

[phoddie]

😱

[phoddie]

I tried again. ;) Any better?

[MKGaru]

Excellent!
It's works.
Thank you for update.