Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bit_num -> duty_resolution #1225

Closed
wants to merge 1 commit into from

Conversation

meganetaaan
Copy link
Contributor

Unfortunately, after the fix for #1088, the changes were rolled back by another commit, leading to build failures with ESP-IDF v5.1.1. This is a quick fix for this issue.

For compatibility with ESP-IDF v5.1.1
@phoddie
Copy link
Collaborator

phoddie commented Oct 3, 2023

Yikes! Sorry for the mistake. Thank you for noticing so quickly and reporting the issue.

We can easily merge the PR and update this repository. Is that enough for Stack-chan? Or is it necessary to post another release (4.2.1) for you to use?

@meganetaaan
Copy link
Contributor Author

meganetaaan commented Oct 3, 2023

Thank you for the quick reply.
Yes, v4.2.1 will help us a lot. I found other issues through the test. So I think the v4.2.1 is good after these are resolved.
#1226
#1227

@phoddie
Copy link
Collaborator

phoddie commented Oct 7, 2023

We've pushed the changes for the three issues flagged. Would you please verify that they are all working as you expect? Once that is done, we will prepare the Moddable SDK 4.2.1 release. Thank you.

@meganetaaan
Copy link
Contributor Author

I've confirmed that the serial feature is back working using M5Stack Basic/Core2 👍
I've discovered another issue with the M5Stack CoreS3 where the drawing of Stack-chan's face hangs. This doesn't occur with other M5Stack models, and since examples from ModdableSDK's piu are working, there's a possibility that the issue might be on Stack-chan's side. Regardless, now that it's operational on our primary targets, M5Stack Basic and Core2, I would appreciate it if you could release version v4.2.1.

@phoddie
Copy link
Collaborator

phoddie commented Oct 9, 2023

It is 3 AM! I hope you can get some sleep.

Thank you for the good news. We'll work on getting 4.2.1 posted.

We have seen generally stable results of ESP32-S3. If there's something we can do to help with your investigation on M5Stack CoreS3 let me know.

@phoddie
Copy link
Collaborator

phoddie commented Oct 11, 2023

This has been merged. And Moddable SDK 4.2.1 is live. I hope that's what you need.

@phoddie phoddie closed this Oct 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants