Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wavsteam for OpenAI text-to-speech #1316

Closed

Conversation

stc1988
Copy link
Contributor

@stc1988 stc1988 commented Feb 25, 2024

This PR addd parameter response_format to OpenAI text-to-speech.
Depending on the situation, I think there are cases where wav might be better than mp3.

Furthermore, this PR includes change for the following points.

  • split manifest.json of http-steam into manifest_sbcstreamer.json and manifest_wavstremer.json
  • TLS Certification for OpenAI API.

Copy link
Collaborator

@phoddie phoddie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good. There are just a couple little details to fix.

examples/pins/audioout/openai-stream/openaistreamer.js Outdated Show resolved Hide resolved
examples/pins/audioout/openai-stream/openaistreamer.js Outdated Show resolved Hide resolved
@stc1988
Copy link
Contributor Author

stc1988 commented Feb 27, 2024

Thank you for review.
I fixed review comments

mkellner pushed a commit that referenced this pull request Mar 5, 2024
@stc1988 stc1988 closed this Mar 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants