Add support for M5Stack Core2 v1.1 #1324
Closed
+269
−51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phoddie
reviewed
Mar 21, 2024
| @@ -70,7 +72,14 @@ export default function (done) { | |||
| }; | |||
|
|
|||
| // power | |||
| globalThis.power = new Power(); | |||
| debugger; | |||
There was a problem hiding this comment.
Please remove the debugger statement.
|
Welcome to @RChikamura! Thank you both for the PR. After we receive the CLA, we will look at merging this. |
phoddie
reviewed
Mar 25, 2024
|
This has been merged. Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a pull request to support the minor update version v1.1 of the M5Stack Core2.
In v1.1, the power management IC has been changed from AXP192 to AXP2101 (which is also used in M5Stack CoreS3).
This change has been tested by writing the piu/balls demo to M5Stack v1.0, v1.1, and M5Stack CoreS3, and confirming its operation.
This PR was created with the cooperation of a new contributor, @RChikamura . He has been instructed to submit a CLA.