typings for BLE modules

[chigix]

No description provided.

[phoddie]

Thank you for the PR! It will be great to have TypeScript support or BLE. We'll review this in the coming days.

[phoddie]

What is the reason for removing onDisconnected here?

[phoddie]

Overall this looks good. Before we can merge the PR, you need to provide an executed contributor agreement. You email a signed copy to info@moddable.com.

[chigix]

@phoddie
Exactly, it seems my miss that the onDisconnected method is still existing in BLEClient.
However according to the method definition in BLEClient class:

https://github.com/Moddable-OpenSource/moddable/blob/public/modules/network/ble/bleclient.js#L47

It seems that there is no argument received when onDisconnected invoked.
Can we that method to the declaration of onDisconnect()?

[chigix]

Overall this looks good. Before we can merge the PR, you need to provide an executed contributor agreement. You email a signed copy to info@moddable.com.

Replied just now.

[chigix]

What is the reason for removing onDisconnected here?

@phoddie

After checked the Moddable JavaScript SDK source code again, the class Client exactly has no method defines onDisconnected event listener.

https://github.com/Moddable-OpenSource/moddable/blob/public/modules/network/ble/gatt.js#L23

Instead, I pushed a new commit that fixes the onDisconnected(device):

https://github.com/Moddable-OpenSource/moddable/pull/901/files#diff-c6f2ca436e4bc6ba0016b22f5caecfd6f3b917fba6eedd73c0e52254c21bcea8R287-R294

This definition can be referenced from:
https://github.com/Moddable-OpenSource/moddable/blob/public/modules/network/ble/bleclient.js#L116

[phoddie]

Closing as this was merged back in May. Thanks again!