MODE-1683 Simplified message consuming & receiving; updated delta reconiliation implementation and MapDB version to 0.9.8. #1032
Conversation
| long lastChangeSetTime = -1; | ||
| //get all the existing records in reverse order | ||
| Records allLocalRecords = localJournal.allRecords(true); | ||
| if (allLocalRecords.size() > 0) { |
There was a problem hiding this comment.
Does Records have an isEmpty method? Might be easier or more efficient to implement that, since we don't really care about the size here (and size could be large). Is there not a better way to find the last Record?
There was a problem hiding this comment.
good point(s). I'll update the code.
|
I recently merged PR #1033 and #1034, which changed the licensing (and thus touched most of the source files) in nearly all modules except "modeshape-jcr" and those under the "sequencers" folder. Those modules have outstanding PRs, and I didn't want to create a bunch of conflicts. There may be a conflict with |
…onciliation implementation and MapDB version to 0.9.8.
… Changed the signature of the methods which used long timestamps to use DateTime(s) and removed unnecessary conversions to UTC.
|
Rebased on latest |
| @@ -62,6 +82,7 @@ public LocalJournal( String journalLocation, | |||
| this.asyncWritesEnabled = asyncWritesEnabled; | |||
| this.maxTimeToKeepEntriesMillis = TimeUnit.DAYS.toMillis(maxDaysToKeepEntries); | |||
| this.stopped = true; | |||
| this.searchTimeDelta = TimeUnit.SECONDS.toMillis(1); | |||
There was a problem hiding this comment.
Where is this magic number coming from?
There was a problem hiding this comment.
from the fact there will always be a slight delay locally from the point in time when a change set is created (session.save) to when it is stored in the journal (notify)
There was a problem hiding this comment.
Can you add a constant with JavaDoc that describes this?
|
The above comment is the only (minor) one, and it looks great. |
|
Amended the commit and extracted a constant. |
…ed various other parts of the code based on code review.
|
Merged onto the 'master' branch. |
This PR does not use the counter based approach from #1030. Than can be changed later on.