MODE-1176 Changed ModeShapeUnitTest to correctly find config files on classpath #110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… classpath When the 'startEngineUsing' method was called by a static method, it could not determine the classloader and thus could not find the configuration file that was on the classpath. The solution was to add another form of the method that took the class under test as a second parameter, and to make the 'startEngineUsing(String)' method non-static so that can only be called when the class under test can be determined.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the 'startEngineUsing' method was called by a static method, it could not determine the classloader and thus could not find the configuration file that was on the classpath. The solution was to add another form of the method that took the class under test as a second parameter, and to make the 'startEngineUsing(String)' method non-static so that can only be called when the class under test can be determined.