MODE-2216 Fixed the potential corruption of the workspace cache during concurrent modification of the same nodes. #1138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…g concurrent modifying of the same nodes. With the previous code, multiple session writers of the same nodes could cause a "transient" (local) change to be loaded in the workspace cache during the persistChanges call. This because changed nodes are cleared asynchronously from the workspace cache which is not subject to ISPN locking. The solution was to use a "transient" workspace cache during the persistChanges call, which always contains the latest ISPN stored data after locks has been successfully obtained.
|
Nicely done. I'll build locally and if successful will merge into 'master'. Will we need a different PR for '3.x'? |
|
@rhauch: yes, a separate PR is required for |
rhauch
added a commit
that referenced
this pull request
Jun 2, 2014
MODE-2216 Fixed the potential corruption of the workspace cache during concurrent modification of the same nodes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the previous code, multiple session writers of the same nodes could cause a "transient" (local) change to be loaded in the workspace cache during the
persistChangescall. This because changed nodes are cleared asynchronously from the workspace cache which is not subject to ISPN locking.The solution was to use a "transient" workspace cache during the
persistChangescall, which always contains the latest ISPN stored data after locks have been successfully obtained.