MODE-2160 Added support for an index provider that stores indexes on the local file system #1215
Conversation
…re only a few very limited test cases, but they do pass and show that the provider is able to be included in the query plan, properly selected for use, and properly used during query execution.
…y configuration files
| if (index.getWorkspaceName() != null) { | ||
| str.append(", workspace=").append(index.getWorkspaceName()); | ||
| } | ||
| // if (index.getWorkspaceName() != null) { |
There was a problem hiding this comment.
should this be commented out ?
There was a problem hiding this comment.
Yes, this was intentional. I commented this out so that the printed plan is more readable. I don't think the workspace name of the index adds much to the plan, but I wasn't sure so I didn't delete the code.
|
@rhauch: this looks good to me, although there is stuff which is unclear to me (functional wise). For example |
|
Another question: do we have any WF kit tests which use the new indexing configuration ? For example the current test config XML files have the indexing part disabled. |
|
LOL. The I'll also add a WF kit test that uses the indexes. |
…efinintions before registration.
|
Added another commit that incorporates the aforementioned suggestions, and it also adds support for validating all index definitions (including via the affiliated providers) before any are registered. |
MODE-2160 Added support for an index provider that stores indexes on the local file system
This PR adds support for a new index provider that stores indexes on the local file system using MapDB. This was the first concrete implementation of an index provider, and this helped identify problems in the index provider SPI added in earlier 4.0 alpha releases.
A number of tests were added to show that this new provider does appear to work pretty well, that the query engine is able to use the index providers to plan queries and annotate the query plan with information about applicable indexes, and the engine can then pick and use the best index (if there is one). Additional testing will be completed in other PRs.
The RepositoryConfiguration and JcrRepository classes were modified to support specifying and using indexes within the repository JSON configurations; index support had already been added to the Wildfly subsystem. Additionally, this PR exposes the IndexManager public API for registering new/updated index definitions and for unregistering (removing) index definitions.