MODE-2336 Changed the way ModeShape deals with user transactions #1304
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| public void commit() { | ||
| // This transaction spans more than just our usage, so we don't commit anything here ... | ||
| public void commit() throws RollbackException, HeuristicMixedException, HeuristicRollbackException, SecurityException, IllegalStateException, SystemException { | ||
| //nothing by default |
There was a problem hiding this comment.
Minor detail: these exceptions are unused, so they can be removed from the declaration. (These actually generate warnings in some IDEs and could in checkstyle if we enabled the rule.)
|
Had a few really minor comments and one question; see above. Otherwise, this looks great. |
…tead of using synchronizers which cannot be ordered with respects to ISPN's synchronizer that actually persists the data, ModeShape now uses an Infinispan transaction listener which will only be called once ISPN has processed the transaction.
|
amended the commit based on the previous comments |
hchiorean
pushed a commit
that referenced
this pull request
Oct 24, 2014
MODE-2336 Changed the way ModeShape deals with user transactions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of using synchronizers which cannot be ordered with respects to ISPN's synchronizer that actually persists the data, ModeShape now uses an Infinispan transaction listener which will only be called once ISPN has processed the transaction.
This is the only way that ModeShape can be consistently notified only after ISPN has finished processing a transaction.