MODE-2383 Fixed the way binary distributions are built so that there is no need to install *-with-dependency artifacts in the Maven repository. #1342
Conversation
…is no need to install *-with-dependency artifacts in the Maven repository.
| <includes> | ||
| <include>*:*:*:module-with-dependencies</include> | ||
| </includes> | ||
| </dependencySet> |
There was a problem hiding this comment.
One disadvantage of doing it this way is that we have to explicitly maintain the fileSets when adding/removing modules. Shouldn't be too hard, but we may end up forgetting. I guess we kind of had to do this anyway in the modeshape-distribution.pom, so maybe it's not that much of a change.
OTOH, the big benefit to doing it this way is that no longer do we have to install the with-dependencies artifacts locally or deploy them into the official Maven repository.
Is this correct? Are there other benefits?
There was a problem hiding this comment.
in short, yes: <dependencySet> s are resolved via the Maven repo which in turn, contains only installed artifacts which in turn, must be "attached" (to an assembly) which in turn, will be deployed 😉
|
Overall, I think this looks good. And per my comment above, I think this doesn't really change the amount of work required when adding/removing modules. So assuming my conclusions are correct, this looks good. |
MODE-2383 Fixed the way binary distributions are built so that there is no need to install *-with-dependency artifacts in the Maven repository.
No description provided.