MODE-2408 Fixed the handling of empty ACLs #1371
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| // walk up the hierarchy until we get a set of permissions or we reach the root or a missing parent | ||
| while (permissions == null) { | ||
| // walk up the hierarchy until we get a set of non-empty permissions or we reach the root or a missing parent | ||
| if ((permissions == null || permissions.isEmpty()) && searchParents) { |
There was a problem hiding this comment.
Minor nit: couldn't this line just be if ( searchParents ) { since the permission-related criteria would be handled in the while loop?
|
A few minor nits noted above, but otherwise looks great. |
… the nearest non-empty ones in the hierarchy should be taken into account instead of assuming all permissions are granted on that node.
|
amended the commit based on the previous comments. |
|
Looks great. |
hchiorean
pushed a commit
that referenced
this pull request
Jan 13, 2015
MODE-2408 Fixed the handling of empty ACLs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a node has empty ACLs, then the nearest non-empty ones in the hierarchy should be taken into account instead of assuming all permissions are granted on that node.