MODE-456 Create SequencerOutputMap.addProperty Method #146
Conversation
Added SequencerOutputMap.addPropertyValues(Path, Name, Object...) that adds values to the named property at the given path if it exists, or creates the named property at the given path with the given values if the property did not already exist. This method will cause a PathNotFoundException if no node exists at the given path. Added new tests to verify behavior and did a quick cleanup on the Getting Started guide where a few paragraphs reviewed the custom security context that no longer exists in the sequencer example. All tests pass.
|
I'm getting an error in shouldFindVdbsUsingQueryWithMultipleVariables(org.modeshape.test.integration.sequencer.TeiidSequencerIntegrationTest) every time I run an integration build using these changes. |
|
@bcarothers, I'm still getting the error I mention above, even after I apply your changes to the very latest on 'master'. Note that the failure is because of the test attempting to query the derived content produced by the sequencer. Since this pull-request changes how the derived content is produced/written, I'm concerned the changes are not completely correct. |
|
I'm getting the same thing locally. I agree with your assessment that the fix must not be correct. I haven't had a lot of time to look into the problem though and have no familiarity with the query engine, so this will not be something that I am likely to fix anytime soon. Please feel free to reject the change and close the pull request if that's better than leaving it open until I get this fixed/cleaned up. Thanks |
|
@bcarothers I just merged a change that fixes the query error so that the test case fails by simply reporting the wrong number of expected results. IOW, the generated content is simply not what the queries expect to find, so you shouldn't have to worry about the query engine. Just be sure to rebase your local branch off the latest from 'master'. |
|
Closing WITHOUT merging, due to the aforementioned issues. |
Added SequencerOutputMap.addPropertyValues(Path, Name, Object...) that adds values to the named property at the given path if it exists, or creates the named property at the given path with the given values if the property did not already exist. This method will cause a PathNotFoundException if no node exists at the given path.
Added new tests to verify behavior and did a quick cleanup on the Getting Started guide where a few paragraphs reviewed the custom security context that no longer exists in the sequencer example. All tests pass.