MODE-2634 Replaces ConcurrentLinkedHashmap with Caffeine 2.3.3 #1599
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
unfortunately even though the build is passing on my machine, in Travis it seems to be causing deadlocks in Since there isn't a way to get a thread dump from Travis, I'm not comfortable merging this. We'll leave the JIRA open and at some point later on we can reevaluate this against a newer version of the library perhaps. |
hchiorean
force-pushed
the
MODE-2634
branch
from
54e6484
to
3725d36
Compare
The former is dormant and was designed for pre JDK 8 while the latter is the current active project which uses JDK 8
|
reopened and amended to run the cache's eviction synchronously (based on this comment) |
|
wonderful, the tests passed! :) |
|
@rhauch are you ok with this ? |
|
@hchiorean, looks good. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The former is dormant and was designed for pre JDK 8 while the latter is the current active project which uses JDK 8