MODE-2637 : NullPointerException in IndexChangeAdapter #1606
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hchiorean
reviewed
Nov 15, 2016
| @@ -803,6 +803,11 @@ public NodeTypesChangeAdapter( String property, | |||
| assert this.property != null; | |||
| } | |||
|
|
|||
| private static Object[] valuesOf(Property property) { | |||
| return property.getValuesAsArray() != null ? | |||
| property.getValuesAsArray() : new Object[]{}; | |||
There was a problem hiding this comment.
I think new Object[0]| is more concise, since an empty array initializer doesn't make sense
hchiorean
reviewed
Nov 15, 2016
| @FixFor("MODE-2637") | ||
| public void copyNodeWithEmptyMultiValueProperty() throws Exception { | ||
| // start a repository with some indexes | ||
| String configuration = |
There was a problem hiding this comment.
this should be extracted in a separate JSON configuration file
|
@okulikov : this fixes the symptom of the bug, but I'm not convinced it fixes the original cause: the current code checks that a property If that is the case, IMO this should be fixed and not the current extra checks from |
okulikov
force-pushed
the
MODE-2637
branch
2 times, most recently
from
87ae7bf
to
3c62662
Compare
…nodes in the workspace
|
@okulikov: looks great |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR provides fix which substitutes empty array instead of
nullas value for not assigned multiple-value property.