MODE-2672 Fixes the handling of node removals spanning multiple session saves via the same user transaction #1639
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…on saves via the same user transaction The problem was that the RelationalDb was incorrectly sending back a "dummy" document which had no ID causing subsequent failures. This commit contains an additional (unrelated) change which clears the internal JcrSession state after a successful save or refresh. This should ensure better memory handling as it does not keep "hydrated" JCR node references in the internal cache
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The problem was that the
RelationalDbwas incorrectly sending back a "dummy" document which had no ID causing subsequent failures.This commit contains an additional (unrelated) change which clears the internal
JcrSessionstate after a successfulsaveorrefresh. This should ensure better memory handling as it does not keep "hydrated" JCR node references in the internal cache