MODE-1234 Corrected indexing and querying of BOOLEAN properties #164
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Query nodes based upon custom node types with BOOLEAN properties did work, whereas querying nodes based upon built-in node types with BOOLEAN properties did not work. This fix corrects one error in the way properties are indexed, and another in how constraints against BOOLEAN properties are transformed into Lucene queries. These two errors cancelled each other out for properties on custom node types, but caused issues with properties on built-ins. Once this fix is applied (through an upgrade to 2.6.0.Final, the indexes should be rebuilt to correct the existing indexes. All unit and integration tests pass, including several new tests written to duplicate/verify the problem.
|
Merged into the 'master' and '2.5.x' branches. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Query nodes based upon custom node types with BOOLEAN properties did work, whereas querying nodes based upon built-in node types with BOOLEAN properties did not work. This fix corrects one error in the way properties are indexed, and another in how constraints against BOOLEAN properties are transformed into Lucene queries. These two errors cancelled each other out for properties on custom node types, but caused issues with properties on built-ins.
Once this fix is applied (through an upgrade to 2.6.0.Final, the indexes should be rebuilt to correct the existing indexes.
All unit and integration tests pass, including several new tests written to duplicate/verify the problem.