MODE-1308 Fixed ModeShape to allow any javax.jcr.Binary implementation #232
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| case PropertyType.BINARY: | ||
| return valueFactories.getBinaryFactory().create(value); | ||
| case PropertyType.BINARY: { | ||
| //fix for MODE-1308 - any implementations for javax.jcr.Binary should produce valid values |
There was a problem hiding this comment.
The if-else should be reversed, because our JcrBinary implements javax.jcr.Binary. So as it stands, we're always converting all Binary implementations to new Binary instances. By checking explicitly for JcrBinary, we'll be able to use the instance directly.
One more minor nit pick: the comment above should probably be moved into the if (value instanceof javax.jcr.Binary) block, and say something like "Support any implementation of javax.jcr.Binary (see MODE-1308)". I know this is a subtle change, but it de-emphasizes this as a 'fix' and emphasizes that this is just part of the logic.
|
Merged both commits onto the 'master' branch and cherry-picked onto the '3.x' branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I did look through the code a bit on this one. I've noticed that only -jcr depends on the -graph module, not the other around, so the fix should go inside -jcr.
However, I'm not 100% sure about it (from the design point of view) - there is a test nevertheless which validates it.
If the fix is ok, I can also fix 3.x - will probably be a separate pull request.