MODE-1279 - Fixed repository blocking after performing a full-text search multiple times #299
Conversation
…arch multiple times The fix was part of the ModeShape#207 pull request, which basically removed explicit synchronization around the LuceneSearchProcessor and Engine. In addition: - the lucene version was updated from 3.1.0 to 3.4.0 - the LuceneSearchSession was updated to avoid the possible loss of content when indexing the same content in the same workspace from multiple threads
| @@ -71,10 +71,11 @@ | |||
There was a problem hiding this comment.
Did you intend to make these changes to this file, which appear at first glance to be just formatting changes?
There was a problem hiding this comment.
Changes came as part of the original pull request patch.
There was a problem hiding this comment.
Looking again at the file, they aren't only formatting changes: the queries have an ORDER BY clause added to them. Do you want to discard those ?
There was a problem hiding this comment.
No, we don't want to discard those. I now remember adding the ORDER BY.
|
Overall, the changes look very good except for the files that seem to have only formatting changes. If that's the case, can we remove those files from the pull-request? |
|
Do you want me to revert the above mentioned files ? |
|
If you wouldn't mind, try reverting the two files, moving those 'request.add(NoMoreFederatedRequests)' lines, and running the tests again. |
|
Ok, will update the mentioned files are per comment(s) |
| this.session = this.engine.getRepository(repositoryName) | ||
| .login(new SimpleCredentials("superuser", | ||
| "superuser".toCharArray())); | ||
| this.session = this.engine.getRepository(repositoryName).login(); |
There was a problem hiding this comment.
This change was done because there isn't any authentication configured for the "superuser"/"superuser" credentials and therefore I was getting an "access denied exception" from the repo (or smth similar)
There was a problem hiding this comment.
Oh, I didn't catch that. Any chance of limiting the changes to just the affected lines?
…side finally construct
|
Updated code as per comments: reverted styling and moved NoMoreFederatedRequest inside finally block. |
|
Merged into the 'master' branch. |
The fix was part of the #207 pull request, which basically removed explicit synchronization around the LuceneSearchProcessor and Engine.
In addition: