Mode 1483 - Properties files used for storing extra properties for files and folders are now being removed #379
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…or are now removed. The original problem was caused by the incomplete handling for removal of nodes by the FileSystemWorkspace and the fact that the StoreProperties stores additional file & folder properties in external files (external to the file nodes themselves)
|
I've just spotted an additional problem , please hold off merging until I fix that as well |
|
Fixed problem and updated the integration test. All tests pass. |
|
Merged into the '2.x' branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The original problem was caused by the incomplete handling for removal of nodes by the FileSystemWorkspace and the fact that the StoreProperties stores additional file & folder properties in external files (external to the file nodes themselves)