MODE-1484 Added more error handling to file system connector #380
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The file system connector was not properly handling the case when "java.io.File.list(FilenameFilter)" returns null, which it can sometimes do if there's an I/O error. Now, if this happens, the method call is retried up to 4 more times; after that, if the call still returns null, an error message will be logged and no node will be created for the problematic file. All unit and integration tests pass with these changes.
ghost
assigned 
|
Waiting to merge until the changes can be verified by @jchochol. |
|
Rebased and merged into the '2.x' branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The file system connector was not properly handling the case when "java.io.File.list(FilenameFilter)" returns null, which it can sometimes do if there's an I/O error. Now, if this happens, the method call is retried up to 4 more times; after that, if the call still returns null, an error message will be logged and no node will be created for the problematic file.
All unit and integration tests pass with these changes.