MODE-1462 Added support for a custom logger #400
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ModeShape now supports using a custom logger, allowing applications to provide a 'org.modeshape.common.logging.CustomLoggerFactory' class that will be found and used only after SLF4J and Log4J.
…JBoss AS7 subsystem Several logging dependencies were removed from ModeShape's AS7 subsystem. They apparently aren't needed, since ModeShape uses SLF4J (if it's available, and it is in AS7) and the build works without issue and the subsystem can be deployed to AS7 and used without any issues (and logging works).
…n not running in AS7 The log message isn't needed in our AS7 subsystem because the subsystem always configures some binary store and doesn't rely upon the transient store.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ModeShape now supports using a custom logger, allowing applications to provide a
org.modeshape.common.logging.CustomLoggerFactoryclass that will be found and used only after SLF4J and Log4J (but before the Java Util Logging is used).This is an alternative to this other pull-request.