MODE-1519 Changed JSON configuration format to use "classname" for components #411
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…quencers, extractors, and security providers These components previously used a "type" field to specify the classname or alias, whereas the AS7 configuration uses "classname". The names of these fields were changed to "classname" to be more consistent with the AS7 configuration.
When a repository configuration was updated (e.g., when the sequencers are added to the repository, even in the configuration file), the AS7-specific Environment implementation was being lost, causing a problem finding the correct cache container an cache. The problem was that JcrRepository was not correctly transferring the Environment object to the new/updated RepositoryConfiguration. Once this was done, then everything seems to work just fine.
This commit contains several other minor corrections to ensure that the sequencers can be initialized correctly, and that the AS7 sample repositories are configured properly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The sequencers, extractors, and security providers previously used a "type" field to specify the classname or alias, whereas the AS7 configuration uses "classname". The names of these fields were changed to "classname" to be more consistent with the AS7 configuration.
Note that the binary storage, index storage, and other components are still configured with a "type" field, because that field does not specify a classname, but is instead used as a switch within the JSON Schema.
All unit and integration tests pass with these changes.