MODE-1522 Changed the sequencer portion of the JSON configuration #413
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously the sequencers were defined in the JSON configuration using an array of nested documents. However, this made it difficult to easily identify and update a particular sequencer configuration. And even though the names were intended to be unique, using an array did not enforce that constraint. Finally, the sequencer configurations are not ordered. Now, the 'sequencing/sequencers' field in the JSON configuration files are documents, with the field name containing the unique name of the sequencer. The value of these fields are each the sequencer configuration for the given name. An error in the JSON Schema validation logic was discovered and corrected. Note that very few of the changes involved the production code; most changes were in fact for test code or configurations.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously the sequencers were defined in the JSON configuration using an array of nested documents. However, this made it difficult to easily identify and update a particular sequencer configuration. And even though the names were intended to be unique, using an array did not enforce that constraint. Finally, the sequencer configurations are not ordered.
Now, the 'sequencing/sequencers' field in the JSON configuration files are documents, with the field name containing the unique name of the sequencer. The value of these fields are each the sequencer configuration for the given name.
An error in the JSON Schema validation logic was discovered and corrected. Note that very few of the changes involved the production code; most changes were in fact for test code or configurations.