Mode 1515 - Updated AS7 kit by splitting up the sequencers and common into separate modules #416
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
June 21, 2012 09:40
… AS7 distribution kit
…between modules. Extracting the common module did bring up a small issue in that i18n resources from other modules (e.g. main) could not be loaded. The reason what that the ClasspathLocalizationRepository always used its own CL to load the .properties file, which doesn't work with the AS7 classloading mechanism. The solution was to simplify the loading and always use the class loader of the i18n class which we're trying to localize.
…pdate. This fixes part of the problem described in https://issues.jboss.org/browse/MODE-1516
Since AS7 uses modules dedicated classloaders, it was necessary to update the way in which components (sequencers, extractors etc) are loaded. The solution was to move the classloader creation to the Environment (with the dedicated LocalEnvironment and RepsitoryService implementations) and to use a new class loader implementation: DelegatingClassLoader. This implementation uses an inner list of class loader and delegates each operation to them. In the case of AS7, there is a delegate class loader which uses the ModuleLoader to find the classloader for each module. The changes also contain an update to the common package: the component package and most of its unused classes have been removed. The classes which are still used have been moved to .util.
…rder for all the sequencers to be present in the repository configuration, a workaround with a TODO was added for MODE-1521
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To validate the AS7 kit an Arquillian integration test was added which tests each of the built-in sequencers.
However, for the test to pass, MODE-1521 needs to be fixed. I've added a temporary workaround with a TODO, in the last commit, which allows all the sequencers to be properly configured in AS7